Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust layout and colors of the voice recording view #704

Merged
merged 7 commits into from
Jan 14, 2025

Conversation

laevandus
Copy link
Contributor

@laevandus laevandus commented Jan 7, 2025

🔗 Issue Link

Resolves IOS-621

🎯 Goal

Voice recording view is using layout not matching to design specifications, in addition, some of the colors and images are not configurable.

🛠 Implementation

  • Add ColorPalette.voiceMessageControlBackground and use it for play button's background color
  • Add Images.pauseFilled and use it for play button
  • Use Images.playFilled for the play button
  • Use ColorPalette.messageCurrentUserTextColor or ColorPalette.messageOtherUserTextColor for the title of the VoiceRecordingView
  • Use ColorPalette.highlightedAccentBackground for AudioVisualizationView.highlightedBarColor
  • Adjust corner radii, many spacings, and background colors
  • Update snapshot tests

🧪 Testing

N/A - covered by snapshot tests

🎨 Changes

Please refer to updated snapshots.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Affected documentation updated (docusaurus, tutorial, CMS (task created)

@laevandus laevandus requested a review from a team as a code owner January 7, 2025 09:38
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 7, 2025

SDK Size

title develop branch diff status
StreamChatSwiftUI 7.54 MB 7.54 MB +1 KB 🟢

@laevandus laevandus force-pushed the fix/voice-recording-view branch 2 times, most recently from 98771f4 to 7fcb4b7 Compare January 7, 2025 10:48
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks to good to me, but we are missing some stuff 👍

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@laevandus laevandus force-pushed the fix/voice-recording-view branch from 7fcb4b7 to 3738c4f Compare January 8, 2025 13:44
@laevandus laevandus force-pushed the fix/voice-recording-view branch from 3738c4f to 0240cfa Compare January 8, 2025 13:45
Copy link
Contributor

@martinmitrevski martinmitrevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, let's just align on the naming.

Sources/StreamChatSwiftUI/ColorPalette.swift Outdated Show resolved Hide resolved
@laevandus laevandus changed the title Adjust layout and colors of the voice recording view [WIP] Adjust layout and colors of the voice recording view Jan 13, 2025
@laevandus laevandus changed the title [WIP] Adjust layout and colors of the voice recording view Adjust layout and colors of the voice recording view Jan 13, 2025
Copy link
Member

@nuno-vieira nuno-vieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
67.3% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@laevandus laevandus merged commit d2eb3ce into develop Jan 14, 2025
11 of 12 checks passed
@laevandus laevandus deleted the fix/voice-recording-view branch January 14, 2025 10:40
@Stream-SDK-Bot Stream-SDK-Bot mentioned this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants