-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust layout and colors of the voice recording view #704
Conversation
SDK Size
|
98771f4
to
7fcb4b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks to good to me, but we are missing some stuff 👍
StreamChatSwiftUITests/Tests/ChatChannel/MessageView_Tests.swift
Outdated
Show resolved
Hide resolved
7fcb4b7
to
3738c4f
Compare
3738c4f
to
0240cfa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, let's just align on the naming.
# Conflicts: # CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ✅
Quality Gate failedFailed conditions |
🔗 Issue Link
Resolves IOS-621
🎯 Goal
Voice recording view is using layout not matching to design specifications, in addition, some of the colors and images are not configurable.
🛠 Implementation
ColorPalette.voiceMessageControlBackground
and use it for play button's background colorImages.pauseFilled
and use it for play buttonImages.playFilled
for the play buttonColorPalette.messageCurrentUserTextColor
orColorPalette.messageOtherUserTextColor
for the title of theVoiceRecordingView
ColorPalette.highlightedAccentBackground
forAudioVisualizationView.highlightedBarColor
🧪 Testing
N/A - covered by snapshot tests
🎨 Changes
Please refer to updated snapshots.
☑️ Checklist